Skip to content

DOCSP-29345 - Replace forEach #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2023

Conversation

mongoKart
Copy link
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-29345
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/docsp-29345-remove-foreach/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

Copy link
Collaborator

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ some small suggestions

@@ -25,11 +25,11 @@ information on the parameters you can pass to the method.

The ``find()`` method returns a `FindCursor <{+api+}/classes/FindCursor.html>`__ that
manages the results of your query. You can iterate through the matching
documents using one of the following :ref:`cursor methods <cursor-methods>`:
documents using the ``for await...of`` syntax or one of the following
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
documents using the ``for await...of`` syntax or one of the following
documents using the ``for await...of`` syntax, or one of the following

@mongoKart mongoKart merged commit 0b7bd5f into mongodb:master May 2, 2023
mongoKart added a commit that referenced this pull request May 2, 2023
* replace forEach

* js feedback

(cherry picked from commit 0b7bd5f)
mongoKart added a commit that referenced this pull request May 2, 2023
* replace forEach

* js feedback

(cherry picked from commit 0b7bd5f)
mongoKart added a commit that referenced this pull request May 2, 2023
* replace forEach

* js feedback

(cherry picked from commit 0b7bd5f)
mongoKart added a commit that referenced this pull request May 2, 2023
* replace forEach

* js feedback

(cherry picked from commit 0b7bd5f)
@mongoKart mongoKart deleted the docsp-29345-remove-foreach branch May 2, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants