-
Notifications
You must be signed in to change notification settings - Fork 52
DOCSP-29345 - Replace forEach #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mongoKart
merged 3 commits into
mongodb:master
from
mongoKart:docsp-29345-remove-foreach
May 2, 2023
Merged
DOCSP-29345 - Replace forEach #671
mongoKart
merged 3 commits into
mongodb:master
from
mongoKart:docsp-29345-remove-foreach
May 2, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-smith721
approved these changes
May 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ some small suggestions
source/usage-examples/find.txt
Outdated
@@ -25,11 +25,11 @@ information on the parameters you can pass to the method. | |||
|
|||
The ``find()`` method returns a `FindCursor <{+api+}/classes/FindCursor.html>`__ that | |||
manages the results of your query. You can iterate through the matching | |||
documents using one of the following :ref:`cursor methods <cursor-methods>`: | |||
documents using the ``for await...of`` syntax or one of the following |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
documents using the ``for await...of`` syntax or one of the following | |
documents using the ``for await...of`` syntax, or one of the following |
mongoKart
added a commit
that referenced
this pull request
May 2, 2023
* replace forEach * js feedback (cherry picked from commit 0b7bd5f)
mongoKart
added a commit
that referenced
this pull request
May 2, 2023
* replace forEach * js feedback (cherry picked from commit 0b7bd5f)
mongoKart
added a commit
that referenced
this pull request
May 2, 2023
* replace forEach * js feedback (cherry picked from commit 0b7bd5f)
mongoKart
added a commit
that referenced
this pull request
May 2, 2023
* replace forEach * js feedback (cherry picked from commit 0b7bd5f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-29345
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/docsp-29345-remove-foreach/
Self-Review Checklist