DOCSP-29510: explain how driver handles undefined vals #674

rustagir · 2023-05-03T20:15:32Z

Pull Request Info

JIRA - https://jira.mongodb.org/browse/DOCSP-29510
Staging:
Landing page for new fundamentals section

Undefined values page

Self-Review Checklist

Is this free of any warnings or errors in the RST?
Did you run a spell-check?
Did you run a grammar-check?
Are all the links working?

rustagir · 2023-05-03T20:17:08Z

source/fundamentals/crud/write-operations/change-a-document.txt

@@ -205,3 +205,5 @@ inserts a new document with the specified fields and values.
 You cannot modify the ``_id`` field of a document nor change a field to
 a value that violates a unique index constraint. See the MongoDB Server manual
 for more information on :manual:`unique indexes </core/index-unique/>`.
+
+.. include:: /includes/undefined-values-note.rst


I'm undecided on whether this was the right approach, as opposed to making different content for these pages based on the type of write op that they explain. I also couldn't find the right place to put this material, as it didn't seem appropriate to make a whole subsection for it on each page.

We have the UTF-8 Validation docs as a top level page but this and that UTF page are both BSON controls. Maybe there's a merging or nesting that would be sensical given that.

I foresee a near future where we may be adding more coverage of the BSON controls that the driver offers, we just have to make the options more easily understood first.

Just a suggestion, of course!

rustagir · 2023-05-04T20:13:24Z

config/redirects

@@ -17,3 +17,4 @@ raw: ${prefix}/stable -> ${base}/current/
 [*-v5.0]: ${prefix}/${version}/quick-start/download-and-install/ -> ${base}/${version}/quick-start/
 [*-v5.0]: ${prefix}/${version}/quick-start/next-steps/ -> ${base}/${version}/quick-start/

+[v4.3-master]: ${prefix}/${version}/fundamentals/utf8-validation -> ${base}/${version}/fundamentals/bson/utf8-validation/


mut redirect test

jordan-smith721

Nice work on this! I've got a few suggestions that I think could make the page a bit easier to digest with how technical it is.

source/fundamentals/bson/undefined-values.txt

jordan-smith721

Nice work with the second pass! LGTM with one small suggestion

jordan-smith721 · 2023-05-05T18:30:07Z

source/fundamentals/bson/undefined-values.txt

+The following example inserts two documents. One insert operation has
+the ``ignoreUndefined`` setting set to ``true``. The driver does not
+serialize the ``salesTax`` field during the first insert operation
+because we specified the ``ignoreUndefined`` setting:


Suggestion: I think these sentences can be combined:

Suggested change

The following example inserts two documents. One insert operation has

the ``ignoreUndefined`` setting set to ``true``. The driver does not

serialize the ``salesTax`` field during the first insert operation

because we specified the ``ignoreUndefined`` setting:

The following example inserts two documents. The first insert operation has

the ``ignoreUndefined`` setting set to ``true``, so it does not

serialize the ``salesTax`` field.

* DOCSP-29510: explain how driver handles undefined vals * make new subfolder for bson * tree fixes and redirect-- snooty stuff * fix version in redirect * fix highlight * JS PR fixes 1 * JS suggestion (cherry picked from commit 52daa59)

* DOCSP-29510: explain how driver handles undefined vals (#674) * DOCSP-29510: explain how driver handles undefined vals * make new subfolder for bson * tree fixes and redirect-- snooty stuff * fix version in redirect * fix highlight * JS PR fixes 1 * JS suggestion (cherry picked from commit 52daa59) * redirect file revert

* DOCSP-29510: explain how driver handles undefined vals (mongodb#674) * DOCSP-29510: explain how driver handles undefined vals * make new subfolder for bson * tree fixes and redirect-- snooty stuff * fix version in redirect * fix highlight * JS PR fixes 1 * JS suggestion (cherry picked from commit 52daa59) * redirect file revert (cherry picked from commit 157f483)

* DOCSP-29510: explain how driver handles undefined vals (#674) * DOCSP-29510: explain how driver handles undefined vals * make new subfolder for bson * tree fixes and redirect-- snooty stuff * fix version in redirect * fix highlight * JS PR fixes 1 * JS suggestion (cherry picked from commit 52daa59) * redirect file revert (cherry picked from commit 157f483)

* DOCSP-29510: explain how driver handles undefined vals (#674) * DOCSP-29510: explain how driver handles undefined vals * make new subfolder for bson * tree fixes and redirect-- snooty stuff * fix version in redirect * fix highlight * JS PR fixes 1 * JS suggestion (cherry picked from commit 52daa59) * redirect file revert (cherry picked from commit 157f483) (cherry picked from commit f7c1609)

* DOCSP-29510: explain how driver handles undefined vals (#674) * DOCSP-29510: explain how driver handles undefined vals * make new subfolder for bson * tree fixes and redirect-- snooty stuff * fix version in redirect * fix highlight * JS PR fixes 1 * JS suggestion (cherry picked from commit 52daa59) * redirect file revert (cherry picked from commit 157f483) (cherry picked from commit f7c1609) (cherry picked from commit 82a8fff)

* DOCSP-29510: explain how driver handles undefined vals (#674) * DOCSP-29510: explain how driver handles undefined vals * make new subfolder for bson * tree fixes and redirect-- snooty stuff * fix version in redirect * fix highlight * JS PR fixes 1 * JS suggestion (cherry picked from commit 52daa59) * redirect file revert (cherry picked from commit 157f483) (cherry picked from commit f7c1609) (cherry picked from commit 82a8fff) (cherry picked from commit d2b072b)

* DOCSP-29510: explain how driver handles undefined vals (mongodb#674) * DOCSP-29510: explain how driver handles undefined vals * make new subfolder for bson * tree fixes and redirect-- snooty stuff * fix version in redirect * fix highlight * JS PR fixes 1 * JS suggestion (cherry picked from commit 52daa59) * redirect file revert (cherry picked from commit 157f483) (cherry picked from commit f7c1609) (cherry picked from commit 82a8fff) (cherry picked from commit d2b072b)

* DOCSP-29510: explain how driver handles undefined vals (#674) * DOCSP-29510: explain how driver handles undefined vals * make new subfolder for bson * tree fixes and redirect-- snooty stuff * fix version in redirect * fix highlight * JS PR fixes 1 * JS suggestion (cherry picked from commit 52daa59) * redirect file revert (cherry picked from commit 157f483) (cherry picked from commit f7c1609) (cherry picked from commit 82a8fff) (cherry picked from commit d2b072b)

* DOCSP-29510: explain how driver handles undefined vals (#674) * DOCSP-29510: explain how driver handles undefined vals * make new subfolder for bson * tree fixes and redirect-- snooty stuff * fix version in redirect * fix highlight * JS PR fixes 1 * JS suggestion (cherry picked from commit 52daa59) * redirect file revert (cherry picked from commit 157f483) (cherry picked from commit f7c1609) (cherry picked from commit 82a8fff) (cherry picked from commit d2b072b) (cherry picked from commit d3b2847)

* DOCSP-29510: explain how driver handles undefined vals (#674) * DOCSP-29510: explain how driver handles undefined vals * make new subfolder for bson * tree fixes and redirect-- snooty stuff * fix version in redirect * fix highlight * JS PR fixes 1 * JS suggestion (cherry picked from commit 52daa59) * redirect file revert (cherry picked from commit 157f483) (cherry picked from commit f7c1609) (cherry picked from commit 82a8fff) (cherry picked from commit d2b072b) (cherry picked from commit d3b2847) (cherry picked from commit 5a50abe)

* DOCSP-29510: explain how driver handles undefined vals (mongodb#674) * DOCSP-29510: explain how driver handles undefined vals * make new subfolder for bson * tree fixes and redirect-- snooty stuff * fix version in redirect * fix highlight * JS PR fixes 1 * JS suggestion (cherry picked from commit 52daa59) * redirect file revert (cherry picked from commit 157f483) (cherry picked from commit f7c1609) (cherry picked from commit 82a8fff) (cherry picked from commit d2b072b) (cherry picked from commit d3b2847)

* DOCSP-29510: explain how driver handles undefined vals * make new subfolder for bson * tree fixes and redirect-- snooty stuff * fix version in redirect * fix highlight * JS PR fixes 1 * JS suggestion

DOCSP-29510: explain how driver handles undefined vals

afbfdd7

rustagir commented May 3, 2023

View reviewed changes

rustagir marked this pull request as draft May 3, 2023 20:41

rustagir added 2 commits May 4, 2023 15:45

make new subfolder for bson

1251de5

tree fixes and redirect-- snooty stuff

785f8e2

rustagir marked this pull request as ready for review May 4, 2023 20:07

fix version in redirect

8d468f2

rustagir commented May 4, 2023

View reviewed changes

fix highlight

3f5d097

jordan-smith721 requested changes May 5, 2023

View reviewed changes

JS PR fixes 1

3681561

rustagir requested a review from jordan-smith721 May 5, 2023 17:24

jordan-smith721 approved these changes May 5, 2023

View reviewed changes

JS suggestion

754b7be

rustagir merged commit 52daa59 into mongodb:master May 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

DOCSP-29510: explain how driver handles undefined vals #674

DOCSP-29510: explain how driver handles undefined vals #674

Uh oh!

rustagir commented May 3, 2023 •

edited

Loading

Uh oh!

rustagir May 3, 2023

Uh oh!

nbbeeken May 3, 2023

Uh oh!

rustagir May 4, 2023

Uh oh!

jordan-smith721 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jordan-smith721 left a comment

Uh oh!

jordan-smith721 May 5, 2023

Uh oh!

Uh oh!

DOCSP-29510: explain how driver handles undefined vals #674

DOCSP-29510: explain how driver handles undefined vals #674

Uh oh!

Conversation

rustagir commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Info

Self-Review Checklist

Uh oh!

rustagir May 3, 2023

Choose a reason for hiding this comment

Uh oh!

nbbeeken May 3, 2023

Choose a reason for hiding this comment

Uh oh!

rustagir May 4, 2023

Choose a reason for hiding this comment

Uh oh!

jordan-smith721 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jordan-smith721 left a comment

Choose a reason for hiding this comment

Uh oh!

jordan-smith721 May 5, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rustagir commented May 3, 2023 •

edited

Loading