DOCSP-29676 v5.4 update #675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongoKart
requested changes
May 4, 2023
source/whats-new.txt
Outdated
|
|
||
| .. important:: Deprecation Notice | ||
|
|
||
| - The ``collStats`` helper is deprecated. Use the :manual:`$collStats |
There was a problem hiding this comment.
S: Looking at the JIRA ticket, collStats is a helper command. Might be useful to specify here.
Suggested change
| - The ``collStats`` helper is deprecated. Use the :manual:`$collStats | |
| - The ``collStats`` helper command is deprecated. Use the :manual:`$collStats |
source/whats-new.txt
Outdated
Comment on lines
50
to
51
| - Methods of ``db.command()`` that were incorrectly included in the | ||
| typescript interface have been deprecated. |
There was a problem hiding this comment.
I: I think these were options, not methods.
Suggested change
| - Methods of ``db.command()`` that were incorrectly included in the | |
| typescript interface have been deprecated. | |
| - The TypeScript interface passed to the ``db.command()`` method incorrectly | |
| includes certain options. These options have been deprecated. |
There was a problem hiding this comment.
Oops, good catch. Changed
source/whats-new.txt
Outdated
| - Methods of ``db.command()`` that were incorrectly included in the | ||
| typescript interface have been deprecated. | ||
|
|
||
| - The ``ChangeStream.tryNext`` method now uses the ``TChange`` schema |
There was a problem hiding this comment.
Suggested change
| - The ``ChangeStream.tryNext`` method now uses the ``TChange`` schema | |
| - The ``ChangeStream.tryNext()`` method now uses the ``TChange`` schema |
source/whats-new.txt
Outdated
Comment on lines
53
to
54
| - The ``ChangeStream.tryNext`` method now uses the ``TChange`` schema | ||
| generic instead of the untyped ``Document`` interface. |
There was a problem hiding this comment.
S: Something like:
Suggested change
| - The ``ChangeStream.tryNext`` method now uses the ``TChange`` schema | |
| generic instead of the untyped ``Document`` interface. | |
| - The ``ChangeStream.tryNext`` method now uses the schema-specific | |
| ``TChange`` generic type instead of the ``Document`` interface. |
mongoKart
pushed a commit
to mongoKart/docs-node
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-29676
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/DOCSP-29676-v5.4-release/
Self-Review Checklist