DOCSP-29805: no query criteria in find #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DBirtolo-mdb
suggested changes
May 11, 2023
Comment on lines
66
to
68
| If you don't pass a query or pass an empty query | ||
| to the ``findOne()`` method, the operation returns the first | ||
| document of a collection. |
There was a problem hiding this comment.
[question]
Is this accurate? I thought it returned a random one, not a guaranteed first one.
There was a problem hiding this comment.
In my testing, it is always the first one, but here's what the Manual says:
Returns one document that satisfies the specified query criteria on the collection or view. If multiple documents satisfy the query, this method returns the first document according to the natural order which reflects the order of documents on the disk.
Maybe it's best to be on the safe side and just say a single document
Comment on lines
70
to
71
| Even if you pass an empty query in a find operation, you can | ||
| specify options. For example, the following code shows how you can |
There was a problem hiding this comment.
[suggestion]
I'd recommend switching this to put the imperative of what readers can do before the conditional.
Suggested change
| Even if you pass an empty query in a find operation, you can | |
| specify options. For example, the following code shows how you can | |
| You can | |
| specify options in a find operation even when you pass an empty query. For example, the following code shows how you can |
rustagir
added a commit
that referenced
this pull request
May 12, 2023
* DOCSP-29805: find op with no/empty query document * wording fixes * replace refs while im here * DB PR fixes 1 (cherry picked from commit a4883c9)
rustagir
added a commit
that referenced
this pull request
May 12, 2023
* DOCSP-29805: find op with no/empty query document * wording fixes * replace refs while im here * DB PR fixes 1 (cherry picked from commit a4883c9)
rustagir
added a commit
that referenced
this pull request
May 12, 2023
* DOCSP-29805: find op with no/empty query document * wording fixes * replace refs while im here * DB PR fixes 1 (cherry picked from commit a4883c9)
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
rustagir
added a commit
that referenced
this pull request
May 12, 2023
jordan-smith721
pushed a commit
to jordan-smith721/docs-node
that referenced
this pull request
Jul 24, 2023
mongoKart
pushed a commit
to mongoKart/docs-node
that referenced
this pull request
Nov 3, 2023
* DOCSP-29805: find op with no/empty query document * wording fixes * replace refs while im here * DB PR fixes 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - DOCSP-29805
Staging
Self-Review Checklist