Skip to content

DOCSP-29819: type regression issue fixed in 4.8.1 #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2023

Conversation

rustagir
Copy link
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - DOCSP-29819
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/DOCSP-29819-set-operator-issue-4.8/whats-new/#what-s-new-in-4.8

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

Copy link
Contributor

@DBirtolo-mdb DBirtolo-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion

Comment on lines 377 to 378
Version 4.8.1 includes a fix to a type regression issue that was
introduced in v4.8.0. By upgrading to v4.8.1, you can specify ``_id``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion

Language tightening

Suggested change
Version 4.8.1 includes a fix to a type regression issue that was
introduced in v4.8.0. By upgrading to v4.8.1, you can specify ``_id``
Version 4.8.1 fixes a type regression issue
introduced in v4.8.0. By upgrading to v4.8.1, you can specify ``_id``

@rustagir rustagir merged commit 693e7ab into mongodb:master May 17, 2023
rustagir added a commit that referenced this pull request May 17, 2023
* DOCSP-29819: type regression issue fixed in 4.8.1

* DB PR fixes 1

(cherry picked from commit 693e7ab)
rustagir added a commit that referenced this pull request May 17, 2023
* DOCSP-29819: type regression issue fixed in 4.8.1

* DB PR fixes 1

(cherry picked from commit 693e7ab)
rustagir added a commit that referenced this pull request May 17, 2023
* DOCSP-29819: type regression issue fixed in 4.8.1

* DB PR fixes 1

(cherry picked from commit 693e7ab)
rustagir added a commit that referenced this pull request May 17, 2023
* DOCSP-29819: type regression issue fixed in 4.8.1

* DB PR fixes 1

(cherry picked from commit 693e7ab)
rustagir added a commit that referenced this pull request May 17, 2023
* DOCSP-29819: type regression issue fixed in 4.8.1

* DB PR fixes 1

(cherry picked from commit 693e7ab)
rustagir added a commit that referenced this pull request May 17, 2023
* DOCSP-29819: type regression issue fixed in 4.8.1

* DB PR fixes 1

(cherry picked from commit 693e7ab)
rustagir added a commit that referenced this pull request May 17, 2023
* DOCSP-29819: type regression issue fixed in 4.8.1

* DB PR fixes 1

(cherry picked from commit 693e7ab)
rustagir added a commit that referenced this pull request May 17, 2023
* DOCSP-29819: type regression issue fixed in 4.8.1

* DB PR fixes 1

(cherry picked from commit 693e7ab)
rustagir added a commit that referenced this pull request May 17, 2023
* DOCSP-29819: type regression issue fixed in 4.8.1

* DB PR fixes 1

(cherry picked from commit 693e7ab)
rustagir added a commit that referenced this pull request May 17, 2023
* DOCSP-29819: type regression issue fixed in 4.8.1

* DB PR fixes 1

(cherry picked from commit 693e7ab)
rustagir added a commit that referenced this pull request May 17, 2023
* DOCSP-29819: type regression issue fixed in 4.8.1

* DB PR fixes 1

(cherry picked from commit 693e7ab)
rustagir added a commit that referenced this pull request May 17, 2023
* DOCSP-29819: type regression issue fixed in 4.8.1

* DB PR fixes 1

(cherry picked from commit 693e7ab)
rustagir added a commit that referenced this pull request May 17, 2023
* DOCSP-29819: type regression issue fixed in 4.8.1

* DB PR fixes 1

(cherry picked from commit 693e7ab)
rustagir added a commit that referenced this pull request May 17, 2023
* DOCSP-29819: type regression issue fixed in 4.8.1

* DB PR fixes 1

(cherry picked from commit 693e7ab)
mongoKart pushed a commit to mongoKart/docs-node that referenced this pull request Nov 3, 2023
* DOCSP-29819: type regression issue fixed in 4.8.1

* DB PR fixes 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants