Speedup of calc_release_version.py #1383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable debug output in calc-version selftest
Instead of continually asking Git whether a particular commit hash is pointed-to by a given tag, ask Git upfront for a mapping between all commit hashes and the associated tags. Then, look for the commit in the mapping as a single step.
rcsanchez97
reviewed
Aug 16, 2023
There was a problem hiding this comment.
As I mentioned in a comment to #1382 , the algorithm in this script (which is shared across the C driver, C++ driver, and libmongocrypt) still needs to function on Python 2.6. While I like the changes, I am not sure that these will work on older Python implementations. Do you know if that presents a problem for what you want to do?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds some minor stylistic changes and a significant speedup for calc_release_version. Refer to 18b2dde for details.