CDRIVER-4766 cast size_t/ssize_t to long #1465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes compilation failure when %ld format specifier is used on 32-bit platforms. Ref: https://bugs.debian.org/1055264
kkloberdanz
reviewed
Nov 3, 2023
|
Patch build specifically for the last commit: https://spruce.mongodb.com/version/6544fdbf0ae6063341dcc24b/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC |
kkloberdanz
approved these changes
Nov 3, 2023
rcsanchez97
added a commit
that referenced
this pull request
Nov 3, 2023
* add 32-bit Debian package build * CDRIVER-4766 replace %ld with %zu in TRACEs This fixes compilation failure when %ld format specifier is used on 32-bit platforms. Ref: https://bugs.debian.org/1055264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes compilation failure when %ld format specifier is used on 32-bit platforms.
Ref: https://bugs.debian.org/1055264
This PR also adds a Debian packaging build for 32-bit (i386) architecture.
Patch build that adds the 32-bit Debian packaging build and shows the compilation failure: https://spruce.mongodb.com/version/6544461e32f417938789cb2b/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
Patch build with the fix in this PR: https://spruce.mongodb.com/version/65444681c9ec44cc612a0da4/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
NB: After merging I will cherry-pick this to
r1.25.