Allow mongoc_buffer_t larger than INT_MAX #1467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriandole
force-pushed
the
HELP-51931
branch
from
acaa430 to
28b4048
Compare
adriandole
force-pushed
the
HELP-51931
branch
from
c94ea07 to
8dddd1f
Compare
adriandole
commented
Nov 6, 2023
| @@ -5080,6 +5080,49 @@ test_bulk_write_set_client_after_operation (void) | |||
| mongoc_client_destroy (client); | |||
| } | |||
|
|
|||
| // Test creating a bulk write with more data than INT_MAX. | |||
There was a problem hiding this comment.
Removed this test because it kept getting killed for excessive memory use. See passing runs here.
eramongodb
approved these changes
Nov 6, 2023
Comment on lines
+38
to
+39
| buffer->datalen = bson_next_power_of_two (buffer->len + data_size); | ||
| buffer->data = (uint8_t *) buffer->realloc_func ( |
There was a problem hiding this comment.
Consider adding a size_t overflow check.
const size_t new_datalen = bson_next_power_of_two (buffer->len + data_size);
BSON_ASSERT (new_datalen > buffer->datalen); // Overflow check.
buffer->datalen = bson_next_power_of_two (new_datalen);
kkloberdanz
approved these changes
Nov 6, 2023
kevinAlbs
pushed a commit
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary assertion that
mongoc_buffer_tis smaller thanINT_MAX. Slight refactor.