Skip to content

VS-168: Update analyzer rules #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

VS-168: Update analyzer rules #92

merged 1 commit into from
May 2, 2025

Conversation

BorisDog
Copy link
Collaborator

@BorisDog BorisDog commented May 1, 2025

No description provided.

@BorisDog BorisDog requested a review from sanych-sun May 1, 2025 22:15
Copy link
Member

@sanych-sun sanych-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + minor suggestion

@@ -40,7 +40,7 @@ public MQLResult GenerateMql(string methodName)
{
var mqlMethod = _testClassType.GetMethod(methodName);

var executeResult = mqlMethod.Invoke(null, new object[] { });
var executeResult = mqlMethod.Invoke(null, []);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Array.Empty?

@sanych-sun sanych-sun self-requested a review May 2, 2025 18:41
Copy link
Member

@sanych-sun sanych-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BorisDog BorisDog merged commit e5cd612 into mongodb:main May 2, 2025
4 checks passed
@BorisDog BorisDog deleted the vs168 branch May 2, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants