Skip to content

CDRIVER-2813 Remove ENABLE_EXTRA_ALIGNMENT (CXX-3260) #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 1, 2025

Conversation

eramongodb
Copy link
Contributor

Followup to mongodb/mongo-c-driver#1942.

Partially reverts the changes in #1329 pertaining to dynamic allocation of types inheriting extended alignment requirements (e.g. bson_t -> bsoncxx::aligned_storage<bson_t>). Changes pertaining to handling of ignored attributes for template parameters are still necessary. All EVG task coverage specific to configuration with ENABLE_EXTRA_ALIGNMENT are removed.

@eramongodb eramongodb requested a review from kevinAlbs March 31, 2025 15:50
@eramongodb eramongodb self-assigned this Mar 31, 2025
@eramongodb eramongodb changed the title CDRIVER-2813 Remove ENABLE_EXTRA_ALIGNMENT from EVG config CDRIVER-2813 Remove ENABLE_EXTRA_ALIGNMENT from EVG config (CXX-3260) Mar 31, 2025
@eramongodb eramongodb changed the title CDRIVER-2813 Remove ENABLE_EXTRA_ALIGNMENT from EVG config (CXX-3260) CDRIVER-2813 Remove ENABLE_EXTRA_ALIGNMENT (CXX-3260) Mar 31, 2025
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Satisfying to see the reduced test matrix and workaround removals.

@eramongodb eramongodb merged commit 197e279 into mongodb:master Apr 1, 2025
12 of 20 checks passed
@eramongodb eramongodb deleted the cxx-cdriver-2813 branch April 1, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants