Auto download C Driver #967

kkloberdanz · 2023-05-18T14:36:17Z

CXX-2695

Auto download the C driver if it is not already installed.
Make auto downloading the C driver the default for CI.
Libmongocrypt is not yet supported for auto downloading, so use the classic method of installing the C driver separately for tasks that require libmongocrypt.

CMakeLists.txt

cmake/MongocxxUtil.cmake

src/bsoncxx/test/CMakeLists.txt

src/mongocxx/CMakeLists.txt

src/mongocxx/test/CMakeLists.txt

Co-authored-by: vector-of-bool <[email protected]>

CMakeLists.txt

src/bsoncxx/test/CMakeLists.txt

Co-authored-by: Roberto C. Sánchez <[email protected]>

CMakeLists.txt

src/bsoncxx/test/CMakeLists.txt

CMakeLists.txt

kevinAlbs · 2023-05-25T20:07:05Z

.evergreen/compile.sh

I expect the automatic C driver install may be the default process for new users installing the C++ driver from source.

I suggest:

Update most tasks in Evergreen to remove the install_c_driver function and instead rely on the Auto download C Driver feature. That may provide more test coverage over the default process.

Add one task that uses install_c_driver to test building with a separate C driver install.

CMakeLists.txt

kevinAlbs · 2023-05-25T20:19:34Z

src/mongocxx/CMakeLists.txt

@@ -69,7 +66,6 @@ else()
      find_package(libmongoc-${LIBMONGOC_REQUIRED_ABI_VERSION} ${LIBMONGOC_REQUIRED_VERSION} REQUIRED)
      message ("found libmongoc version ${MONGOC_VERSION}")
      set(libmongoc_target ${MONGOC_LIBRARIES})
-      set(libmongoc_include_directories ${MONGOC_INCLUDE_DIRS})


Is libmongoc_include_directories not needed? libmongoc_include_directories is referenced in MongocxxUtil.cmake.

This was removed by the following suggestion. @vector-of-bool would you please be able to chime in on the reason for requesting this change?

If you link to the libmongoc imported targets, the headers search paths for libmongoc will be propagated into users automatically.

Co-authored-by: Kevin Albertson <[email protected]>

.mci.yml

rcsanchez97 · 2023-07-27T17:58:17Z

CMakeLists.txt

+    )
+
+    if(NOT CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+        set(CMAKE_C_FLAGS -Wno-error)


I think that you will get a better result by doing something like this:

# Disable all warnings for compiling the C driver target_compile_options (mongo::mongoc_shared PRIVATE -w) target_compile_options (mongo::mongoc_static PRIVATE -w)

This would go after the add_subdirectory call and would replace all of the flag manipulation you have here.

For reference, this idea is based on what we do with zlib, in src/libmongoc/CMakeLists.txt:L78-79.

docs/content/mongocxx-v3/installation/advanced.md

Co-authored-by: Roberto C. Sánchez <[email protected]>

Co-authored-by: Kevin Albertson <[email protected]>

This reverts commit de87767.

.mci.yml

Co-authored-by: Kevin Albertson <[email protected]>

Auto download the C driver if it is not already installed

cd6f3e2

kkloberdanz force-pushed the auto-download-c-driver branch from 7d222a9 to cd6f3e2 Compare May 24, 2023 14:32

pin to latest C driver

e199b78

kkloberdanz marked this pull request as ready for review May 24, 2023 17:09

kkloberdanz requested review from rcsanchez97, kevinAlbs and vector-of-bool May 24, 2023 17:09

vector-of-bool requested changes May 24, 2023

View reviewed changes

kkloberdanz and others added 11 commits May 24, 2023 14:51

Update CMakeLists.txt

2660f5a

Co-authored-by: vector-of-bool <[email protected]>

Update CMakeLists.txt

9ea5b52

Co-authored-by: vector-of-bool <[email protected]>

Update CMakeLists.txt

51d91ee

Co-authored-by: vector-of-bool <[email protected]>

Update CMakeLists.txt

599ca9d

Co-authored-by: vector-of-bool <[email protected]>

Update cmake/BsoncxxUtil.cmake

81a6b7c

Co-authored-by: vector-of-bool <[email protected]>

Update cmake/MongocxxUtil.cmake

16b115a

Co-authored-by: vector-of-bool <[email protected]>

Update src/mongocxx/test/CMakeLists.txt

67037d0

Co-authored-by: vector-of-bool <[email protected]>

Update src/mongocxx/CMakeLists.txt

d7de582

Co-authored-by: vector-of-bool <[email protected]>

Update src/mongocxx/CMakeLists.txt

086a134

Co-authored-by: vector-of-bool <[email protected]>

dont need to call ExternalProject_Add and dont need to cache variable

dce2690

it appears this variable must be CACHE'ed

0654a5a

rcsanchez97 reviewed May 25, 2023

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

src/bsoncxx/test/CMakeLists.txt Outdated Show resolved Hide resolved

kkloberdanz and others added 2 commits May 25, 2023 11:22

initialize NEED_DOWNLOAD_C_DRIVER as a simple cmake variable

fec94f4

Update CMakeLists.txt

a921a7c

Co-authored-by: Roberto C. Sánchez <[email protected]>

kevinAlbs requested changes May 25, 2023

View reviewed changes

kkloberdanz and others added 7 commits May 25, 2023 15:27

Update CMakeLists.txt

c28eec5

Co-authored-by: Kevin Albertson <[email protected]>

Update CMakeLists.txt

f30f17c

Co-authored-by: Kevin Albertson <[email protected]>

Update CMakeLists.txt

d805d46

Co-authored-by: Kevin Albertson <[email protected]>

Update CMakeLists.txt

04fbff6

Co-authored-by: Kevin Albertson <[email protected]>

don't make tests opt-in for this PR

6f7227f

add LIBMONGOC_DOWNLOAD_VERSION

b604f40

this variable is no longer used

6477f54

kkloberdanz and others added 9 commits July 27, 2023 10:15

Update CMakeLists.txt

d34fcd8

Co-authored-by: Kevin Albertson <[email protected]>

Update CMakeLists.txt

bf68afa

Co-authored-by: Kevin Albertson <[email protected]>

Update docs/content/mongocxx-v3/installation/advanced.md

ba550a9

Co-authored-by: Kevin Albertson <[email protected]>

Update docs/content/mongocxx-v3/installation/linux.md

8914c8a

Co-authored-by: Kevin Albertson <[email protected]>

Update docs/content/mongocxx-v3/installation/macos.md

e290b37

Co-authored-by: Kevin Albertson <[email protected]>

Update docs/content/mongocxx-v3/installation/advanced.md

bc9d572

Co-authored-by: Kevin Albertson <[email protected]>

remove paragraphs describing C deriver auto install as requested

b977253

as suggested, remove mentions of mongo C driver

2f5a2aa

Update .mci.yml

0484da0

Co-authored-by: Kevin Albertson <[email protected]>

rcsanchez97 requested changes Jul 27, 2023

View reviewed changes

kkloberdanz and others added 8 commits July 27, 2023 13:13

Update docs/content/mongocxx-v3/installation/advanced.md

7b55221

Co-authored-by: Roberto C. Sánchez <[email protected]>

Update CMakeLists.txt

4df03a8

Co-authored-by: Kevin Albertson <[email protected]>

'ENABLE_UNINSTALL=OFF' no longer appears to be necessary

95c05dc

install prefix no longer appears necessary

403665d

remove -Wno-error

bd3b78a

rename fetch_latest_cmake to fetch_c_driver_source

c831ec5

dont remove -Werror from CMAKE_CXX_FLAGS

de87767

Revert "dont remove -Werror from CMAKE_CXX_FLAGS"

3533b51

This reverts commit de87767.

kkloberdanz requested review from kevinAlbs and rcsanchez97 August 2, 2023 18:45

kevinAlbs approved these changes Aug 2, 2023

View reviewed changes

.mci.yml Outdated Show resolved Hide resolved

.mci.yml Show resolved Hide resolved

kkloberdanz and others added 2 commits August 2, 2023 15:05

Update .mci.yml

ee573d2

Co-authored-by: Kevin Albertson <[email protected]>

Update .mci.yml

e759cd9

Co-authored-by: Kevin Albertson <[email protected]>

rcsanchez97 approved these changes Aug 2, 2023

View reviewed changes

vector-of-bool approved these changes Aug 3, 2023

View reviewed changes

kkloberdanz merged commit 8a0ffd5 into mongodb:master Aug 3, 2023

kkloberdanz deleted the auto-download-c-driver branch August 3, 2023 19:25

eramongodb mentioned this pull request Aug 9, 2023

CXX-1848 Add sharded cluster test coverage to EVG config #1007

Merged

eramongodb mentioned this pull request Oct 29, 2024

CXX-3126 Refactor EVG config to use config_generator #1244

Merged

eramongodb mentioned this pull request Apr 4, 2025

CXX-3266 avoid inheriting BUILD_VERSION by auto-downloaded C Driver #1373

Merged

Auto download C Driver #967

Auto download C Driver #967

Uh oh!

Conversation

kkloberdanz commented May 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevinAlbs May 25, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kevinAlbs May 25, 2023

Choose a reason for hiding this comment

Uh oh!

kkloberdanz May 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vector-of-bool Aug 3, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rcsanchez97 Jul 27, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kkloberdanz commented May 18, 2023 •

edited

Loading

kkloberdanz May 25, 2023 •

edited

Loading