GODRIVER-2577 Retry heartbeat on timeout to prevent pool cleanup in FAAS pause. #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingyang-hu
force-pushed
the
godriver2577
branch
13 times, most recently
from
2ab94d1 to
c2e0b77
Compare
qingyang-hu
force-pushed
the
godriver2577
branch
from
c2e0b77 to
28c8df9
Compare
qingyang-hu
commented
Nov 18, 2022
matthewdale
reviewed
Nov 22, 2022
benjirewis
reviewed
Nov 28, 2022
qingyang-hu
force-pushed
the
godriver2577
branch
from
117560f to
29a14d0
Compare
benjirewis
approved these changes
Dec 2, 2022
benjirewis
pushed a commit
that referenced
this pull request
Dec 6, 2022
benjirewis
pushed a commit
that referenced
this pull request
Dec 6, 2022
prestonvasquez
pushed a commit
to prestonvasquez/mongo-go-driver
that referenced
this pull request
Dec 8, 2022
prestonvasquez
added a commit
that referenced
this pull request
Dec 8, 2022
* GODRIVER-2651 Break NoWritesPerformed-Only Error Sequence (#1135) Co-authored-by: Qingyang Hu <[email protected]> Co-authored-by: Benjamin Rewis <[email protected]> Co-authored-by: Kevin Albertson <[email protected]> Co-authored-by: Qingyang Hu <[email protected]> Co-authored-by: Benjamin Rewis <[email protected]> * GODRIVER-2333 Assert that Ping op succeeds initial DNS spec tests (#1124) * GODRIVER-2577 Retry heartbeat on timeout to prevent pool cleanup in FAAS pause. (#1133) * resolve merge conflicts Co-authored-by: Qingyang Hu <[email protected]> Co-authored-by: Benjamin Rewis <[email protected]> Co-authored-by: Kevin Albertson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2577
Summary
This fix retries heartbeat on timeout errors to delay pool cleanup by one event loop.
Background & Motivation
Pausing behavior in FAAS environment, e.g. AWS Lambda, causes connection timeout in heartbeat, which then clears the pool.
This fix retries heartbeats on timeout so only two continuous timeout errors will trigger a pool cleanup.
Its test case uses a proxy
net.Connto mimic timeout errors.