Validate RewrapManyDataKeyOptions #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the provider exists if a master key has been provided. JAVA-4717
rozza
requested review from
stIncMale and
jyemin
and removed request for
stIncMale
jyemin
approved these changes
Sep 14, 2022
kevinAlbs
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
LGTM. C has the same bug, and possibly Go. Filed https://jira.mongodb.org/browse/DRIVERS-2441 in case this impacts other drivers.
|
@rozza can this be merged (and also cherry picked to the main branch)? |
rozza
added a commit
that referenced
this pull request
Sep 23, 2022
Ensure that the provider exists if a master key has been provided. JAVA-4717
|
Merged and on master as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the provider exists if a master key has been provided.
JAVA-4717