Move legacy write operations into driver-legacy #1030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyemin
commented
Oct 31, 2022
stIncMale
requested changes
Nov 10, 2022
Comment on lines
43
to
45
| * Abstract base class for legacy write operations. | ||
| */ | ||
| public abstract class BaseWriteOperation implements AsyncWriteOperation<WriteConcernResult>, WriteOperation<WriteConcernResult> { | ||
| class LegacyMixedBulkWriteOperation implements WriteOperation<WriteConcernResult> { |
There was a problem hiding this comment.
This class is no longer abstract, but the doc still says it is.
| final boolean retryWrites, final List<? extends WriteRequest> writeRequests) { | ||
| this.writeRequests = notNull("writeRequests", writeRequests); | ||
| isTrueArgument("writeRequests not empty", !writeRequests.isEmpty()); | ||
| this.type = writeRequests.get(0).getType(); |
There was a problem hiding this comment.
There appears to be nothing preventing writeRequests from containing requests of different types. We can change this by making the constructor private and exposing static methods that take lists of specific types of requests.
|
Changes seem uncontroversial, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4795