Update MongoQueryException to extend MongoCommandException #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyemin
commented
Nov 7, 2022
| * | ||
| * @return the full response to the command failure. | ||
| * @since 4.8 |
There was a problem hiding this comment.
Treating this as an API addition based on the javadoc
rozza
requested changes
Nov 9, 2022
driver-core/src/test/functional/com/mongodb/internal/operation/QueryOperationHelper.groovy
Outdated
Show resolved
Hide resolved
The MongoQueryException class currently extends MongoServerException, the reason being that prior to MongoDB 3.2 the find helper was implemented using the OP_QUERY wire protocol message, which is not a command. But now that 3.6 is the minimum required server version, the find helper is always implemented via the find command. So MongoQueryException can now extend MongoCommandException and include the full command response document. JAVA-4676
JAVA-4676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MongoQueryException class currently extends MongoServerException,
the reason being that prior to MongoDB 3.2 the find helper was implemented
using the OP_QUERY wire protocol message, which is not a command. But now
that 3.6 is the minimum required server version, the find helper is always
implemented via the find command. So MongoQueryException can now extend
MongoCommandException and include the full command response document.
JAVA-4676