Skip to content

Make more packages NotNullApi by default #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2022
Merged

Make more packages NotNullApi by default #1056

merged 1 commit into from
Dec 5, 2022

Conversation

jyemin
Copy link
Collaborator

@jyemin jyemin commented Nov 29, 2022

JAVA-4359

The process I followed:

  1. Add @NonNullApi to package-info.java
  2. Add @Nullable and Assertions.assertNonNull until Spotbugs is happy
  3. Apply a few IntelliJ intentions for things that Spotbugs missed

@jyemin jyemin requested a review from rozza November 29, 2022 15:09
rozza
rozza approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I used the build as the core part of the review - due to the high number of similar changes.

@jyemin jyemin merged commit 261c065 into mongodb:master Dec 5, 2022
@jyemin jyemin deleted the j4359 branch December 5, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozza rozza rozza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyemin @rozza