fix: ensure no NPE is thrown with SerializedFluxSink #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the FluxSink is an instance of SerializedFluxSink and the results contains a null value, a NullPointerException is thrown and the whole process stops. This is because SerializedFluxSink.next performs a call to Object.requireNonNull(). To fix this issue we filter out null values from the results.
|
Thanks |
|
Thanks @imclem for finding this and supplying the fix - merged :) Will be released in the near future. |
|
Thanks for merging |
rozza
pushed a commit
that referenced
this pull request
Mar 31, 2023
When the FluxSink is an instance of SerializedFluxSink and the results contains a null value, a NullPointerException is thrown and the whole process stops. This is because SerializedFluxSink.next performs a call to Object.requireNonNull(). To fix this issue we filter out null values from the results. JAVA-4908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋,
We use Mongodb reactive stream driver with akka-stream and had an issue when trying to upgrade our mongodb driver from 4.1.x to 4.9.0. The same code which was working with 4.1.x does not work anymore with 4.9.0.
We tracked downed the issue and it's happening since the addition of reactor to this project.
The issue is that when performing a find/distinct which returns
nullvalues, when the results are used in aSerializedFluxSinka NullPointerException is thrown and everything stops.This is because
SerializedFluxSink.nextperforms a call toObject.requireNonNull().To fix this NPE we filter out null values from the results.
I'm not sure this is the appropriate way to test/fix, suggestions are welcome.
In the meantime we workaround this on our side by filtering out null values in the query.
Thanks