Skip to content

Improve error message for invalid field names #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Conversation

jyemin
Copy link
Collaborator

@jyemin jyemin commented Jul 25, 2022

For replacement documents, it's now:
"Field names in a replacement document can not start with '$' but '%s' does"
For update documents, it's now:
"All update operators must start with '$', but '%s' does not"

JAVA-2114

For replacement documents, it's now:
  "Field names in a replacement document can not start with '$' but '%s' does"
For update documents, it's now:
  "All update operators must start with '$', but '%s' does not"

JAVA-2114
@jyemin jyemin requested a review from rozza July 25, 2022 20:55
@jyemin jyemin self-assigned this Jul 25, 2022
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - only nit is I don't think you test the getValidationErrorMessageif validate is true logic.

@jyemin
Copy link
Collaborator Author

jyemin commented Jul 26, 2022

Can you elaborate? Not sure what you mean.

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyemin jyemin requested a review from rozza July 26, 2022 14:43
@jyemin jyemin merged commit 6693493 into mongodb:master Jul 26, 2022
@jyemin jyemin deleted the j2114 branch July 26, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants