Remove support for pre-3.6 server releases #988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jyemin Just curious, what was the process for removing support? Were you able to find all locations by following version checks from some single location? (For example, I see that you have removed methods like |
|
Yes, just following version checks and then removing anything unused as a result of removing the version check and any code branches that were no longer needed. |
katcharov
approved these changes
Aug 16, 2022
rozza
approved these changes
Aug 17, 2022
driver-core/src/main/com/mongodb/internal/connection/CommandMessage.java
Outdated
Show resolved
Hide resolved
* Remove query-based support for list collections and indexes * Remove support for MONGDOB-CR as the default authenticator JAVA-4296
* Use killCursors command in cursor cleaner instead of OP_KILL_CURSORS * Remove wire version checks for 3.0 * Remove subsequent dead code JAVA-4297
* Remove wire version check for invalid use of collation * Remove wire version check for invalid use of hint * Remove wire version check for missing user name for X509 authentication JAVA-4298
* Remove wire version check for including cursor field in aggregate command * Remove wire version check for retryable reads and writes * Remove wire version check for use OP_INSERT/UPDATE/DELETE for unacknowledged writes * Remove dead code that supported OP_INSERT/UPDATE/DELETE * Simplify CommandMessage to assume OP_QUERY is not used with payloads (because it's not only used to send the isMaster command) JAVA-4299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4295
I divided this up into a commit for each release that we're dropping. So if we ever need to roll back, it's easy to do it for a single release.
I suggest enabling Hide Whitespace Only Changes in the UI when you review, as many of the lines changed only whitespace based on the removal of conditional statements.