Replace existing SDAM integration spec tests with unified tests #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyemin
commented
Aug 19, 2022
driver-core/src/test/unit/com/mongodb/internal/connection/TestServerListener.java
Show resolved
Hide resolved
driver-core/src/test/unit/com/mongodb/internal/connection/TestServerListener.java
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/ContextElement.java
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/Entities.java
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTest.java
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTest.java
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTest.java
Show resolved
Hide resolved
rozza
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
LGTM
Comment: Given that the unified test code is very abstract, I found that without code familiarity its hard to grok whats going on - especially, when having to implement a new version of Unified Tests. It maybe worth thinking if there is anything that can be done to minimize the steep learning curve/cost in the future. Especially if the code becomes even more complex.
driver-core/src/test/unit/com/mongodb/internal/connection/TestServerListener.java
Show resolved
Hide resolved
driver-core/src/test/unit/com/mongodb/internal/connection/TestServerListener.java
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4658