PYTHON-3256 Obtain AWS credentials for CSFLE in the same way as for MONGODB-AWS #1035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusgeo
reviewed
Aug 11, 2022
test/test_encryption.py
Outdated
| key_vault_client=client_context.client, | ||
| codec_options=OPTS, | ||
| ) | ||
| with self.assertRaises(EncryptionError) as ctx: |
There was a problem hiding this comment.
I don't think this ctx is used.
ShaneHarvey
requested changes
Oct 21, 2022
| "ocsp": pyopenssl_reqs, | ||
| "snappy": ["python-snappy"], | ||
| "zstd": ["zstandard"], | ||
| "aws": ["pymongo-auth-aws<2.0.0"], | ||
| "aws": aws_reqs, |
There was a problem hiding this comment.
Let's update the docs to say that pymongo-auth-aws is also required for encryption in these 3 places:
README.rst:135: $ python -m pip install "pymongo[encryption]"
doc/examples/encryption.rst:30: $ python -m pip install 'pymongo[encryption]'
doc/installation.rst:75: $ python3 -m pip install "pymongo[encryption]"
There was a problem hiding this comment.
Isn't the main point of the extra that the user doesn't need to concern themselves with the libraries used?
There was a problem hiding this comment.
Sure but we should still document what libraries will be installed.
There was a problem hiding this comment.
Note I'm not saying to change those 3 lines in particular. Just the surrounding text. For example the readme says:
Client-Side Field Level Encryption requires `pymongocrypt
<https://pypi.org/project/pymongocrypt/>`_::
$ python -m pip install "pymongo[encryption]"
But this is now incomplete because it doesn't mention pymongo-auth-aws.
ShaneHarvey
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on mongodb/libmongocrypt#440