PYTHON-3860 add types to read_preferences.py #1320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Jul 24, 2023
pymongo/read_preferences.py
Outdated
| """Restore from pickling.""" | ||
| self.__mode = value["mode"] | ||
| self.__mongos_mode = _MONGOS_MODES[self.__mode] | ||
| self.__tag_sets = _validate_tag_sets(value["tag_sets"]) | ||
| self.__max_staleness = _validate_max_staleness(value["max_staleness"]) | ||
| self.__hedge = _validate_hedge(value["hedge"]) | ||
|
|
||
| @abstractmethod | ||
| def __call__(self, selection: Any) -> Any: |
There was a problem hiding this comment.
Could these types be more specific?
test/test_read_preferences.py
Outdated
| @@ -504,7 +504,7 @@ def test_read_preference_document_hedge(self): | |||
| with self.assertRaises(TypeError): | |||
| cls(hedge=[]) # type: ignore | |||
|
|
|||
| pref = cls(hedge={}) | |||
| pref = cls(hedge={}) # type: ignore[abstract] | |||
There was a problem hiding this comment.
was there because _ServerMode's __call__ was abstract. After talking irl, its now not abstract and these type ignore's have been removed
ShaneHarvey
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PYTHON-3860