Skip to content

PYTHON-3909 Fix OIDC reauth for bulk write operations #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 15, 2023

Conversation

ShaneHarvey
Copy link
Member

@ShaneHarvey ShaneHarvey requested a review from a team as a code owner August 11, 2023 18:33
@ShaneHarvey ShaneHarvey requested review from sleepyStick and removed request for a team August 11, 2023 18:33
@blink1073
Copy link
Member

Hmm, I see export DB_USER=, but it is failing to use the username in the default context.

@blink1073
Copy link
Member

I pushed a fix.

@ShaneHarvey
Copy link
Member Author

@blink1073 what's the purpose of AUTH_MECH? I'm wondering if we can just remove it altogether.

@blink1073
Copy link
Member

Yeah, I agree we shouldn't need AUTH_MECH. I'll need to make a PR to drivers-evergreen-tools to not use SCRAM-256 on the OIDC host.

@ShaneHarvey
Copy link
Member Author

ShaneHarvey commented Aug 14, 2023

Yeah, I agree we shouldn't need AUTH_MECH. I'll need to make a PR to drivers-evergreen-tools to not use SCRAM-256 on the OIDC host.

I don't think that's needed. The test client should automatically use SCRAM-SHA-256 by default.

@ShaneHarvey
Copy link
Member Author

Tests are passing besides some broken core doc links:

(api/pymongo/collection: line    1) broken    http://mongodb.com/docs/manual/core/2dsphere/ - 404 Client Error: Not Found for url: https://www.mongodb.com/docs/manual/core/2dsphere/
(api/pymongo/collection: line    1) broken    http://mongodb.com/docs/manual/core/2d/ - 404 Client Error: Not Found for url: https://www.mongodb.com/docs/manual/core/2d/
(api/pymongo/collection: line    1) broken    http://mongodb.com/docs/manual/core/index-hashed/ - 404 Client Error: Not Found for url: https://www.mongodb.com/docs/manual/core/index-hashed/
(api/pymongo/collection: line    1) broken    http://mongodb.com/docs/manual/core/index-text/ - 404 Client Error: Not Found for url: https://www.mongodb.com/docs/manual/core/index-text/

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShaneHarvey ShaneHarvey merged commit 02de1ba into mongodb:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants