Skip to content

PYTHON-3930 Add docs page for network compression #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 1, 2023
Merged

PYTHON-3930 Add docs page for network compression #1415

merged 5 commits into from
Nov 1, 2023

Conversation

ShaneHarvey
Copy link
Member

@ShaneHarvey ShaneHarvey requested a review from a team as a code owner October 31, 2023 21:27
@ShaneHarvey ShaneHarvey requested review from blink1073 and removed request for a team October 31, 2023 21:27
@ShaneHarvey
Copy link
Member Author

Rendered view here: https://pymongo--1415.org.readthedocs.build/en/1415/examples/network_compression.html

blink1073
blink1073 reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also call out zlibCompressionLevel here?

@ShaneHarvey
Copy link
Member Author

Should we also call out zlibCompressionLevel here?

Good idea. Done.

@ShaneHarvey ShaneHarvey requested a review from blink1073 October 31, 2023 23:36
@blink1073
Copy link
Member

Perhaps also link out to https://www.mongodb.com/docs/manual/reference/connection-string/#compression-options?

@ShaneHarvey
Copy link
Member Author

Done, also opened DOCSP-34026 to create a stable dochub link.

blink1073
blink1073 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ShaneHarvey ShaneHarvey merged commit a09a03e into mongodb:master Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaneHarvey @blink1073