Skip to content

PYTHON-3968 Fix mockupdb tox config #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

ShaneHarvey
Copy link
Member

Fixes:

[2023/10/31 23:28:46.782] test-mockupdb: commands[1]> .evergreen/check-c-extensions.sh
[2023/10/31 23:28:46.783] test-mockupdb: failed with .evergreen/check-c-extensions.sh (resolves to .evergreen/check-c-extensions.sh) is not allowed, use allowlist_externals to allow it
[2023/10/31 23:28:46.783] .pkg: _exit> python /opt/python/3.7/lib/python3.7/site-packages/pyproject_api/_backend.py True setuptools.build_meta
[2023/10/31 23:28:46.812]   test-mockupdb: FAIL code 1 (13.87 seconds)
[2023/10/31 23:28:46.812]   evaluation failed :( (13.97 seconds)

@ShaneHarvey ShaneHarvey requested a review from a team as a code owner November 1, 2023 18:47
@ShaneHarvey ShaneHarvey requested review from NoahStapp and blink1073 and removed request for a team November 1, 2023 18:47
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

commands =
{[testenv:test]commands} {posargs} ./test/mockupdb
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

posargs is not needed here because its already added via {[testenv:test]commands}. Having it here actually duplicates the args, eg see how --help becomes --help --help:

 python -m tox -e test-mockupdb -- --help           
.pkg: _optional_hooks> python /Users/shane/work/pycharm/pymongo-py311/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg: get_requires_for_build_sdist> python /Users/shane/work/pycharm/pymongo-py311/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg: build_sdist> python /Users/shane/work/pycharm/pymongo-py311/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta
test-mockupdb: install_package> python -I -m pip install --force-reinstall --no-deps /Users/shane/git/mongo-python-driver/.tox/.tmp/package/73/pymongo-4.6.0.dev0.tar.gz
test-mockupdb: commands[0]> python --version
Python 3.11.4
test-mockupdb: commands[1]> .evergreen/check-c-extensions.sh
running build_ext
test-mockupdb: commands[2]> pytest -v --durations=5 --maxfail=10 --help --help ./test/mockupdb
usage: pytest [options] [file_or_dir] [file_or_dir] [...]

@ShaneHarvey ShaneHarvey merged commit 4b9c5b9 into mongodb:master Nov 1, 2023
@ShaneHarvey ShaneHarvey deleted the PYTHON-3968 branch November 1, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants