PYTHON-2834 Direct read/write retries to another mongos if possible #1421
Conversation
| @@ -1153,3 +1153,9 @@ def prepare_spec_arguments(spec, arguments, opname, entity_map, with_txn_callbac | |||
| raise AssertionError(f"Unsupported cursorType: {cursor_type}") | |||
| else: | |||
| arguments[c2s] = arguments.pop(arg_name) | |||
|
|
|||
|
|
|||
| def set_fail_point(client, command_args): | |||
There was a problem hiding this comment.
Can you use the with self.fail_point() helper instead?
There was a problem hiding this comment.
We need to set the fail point on each individual mongos to ensure the failure occurs on every node. with self.fail_point() does not set the fail point correctly.
| }, | ||
| } | ||
|
|
||
| for mongos in client_context.mongos_seeds().split(","): |
There was a problem hiding this comment.
for mongos in client_context.mongoses:
There was a problem hiding this comment.
That change causes the following error:
h = ('localhost', 27017)
def _connection_string(h):
> if h.startswith(("mongodb://", "mongodb+srv://")):
E AttributeError: 'tuple' object has no attribute 'startswith'
test/utils.py:544: AttributeError
pymongo/mongo_client.py
Outdated
| @@ -2334,6 +2338,8 @@ def run(self) -> T: | |||
| raise | |||
| self._retrying = True | |||
| self._last_error = exc | |||
| if self._client.topology_description.topology_type == TOPOLOGY_TYPE.Sharded: | |||
| self._deprioritized_servers.append(self._server) | |||
There was a problem hiding this comment.
Since this logic is the same for reads and writes and we do it in one place?
There was a problem hiding this comment.
Good catch, thanks!
pymongo/topology.py
Outdated
| if len(servers) == 1: | ||
| return servers[0] | ||
| server1, server2 = random.sample(servers, 2) | ||
| filtered_servers = _filter_servers(servers, deprioritized_servers) |
There was a problem hiding this comment.
Can we rename filtered_servers->servers so the rest of this code doesn't have to change?
No description provided.