Skip to content

PYTHON-3822 Add SRV test with uppercase hostname #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2023
Merged

PYTHON-3822 Add SRV test with uppercase hostname #1423

merged 3 commits into from
Dec 5, 2023

Conversation

ShaneHarvey
Copy link
Member

@ShaneHarvey ShaneHarvey commented Nov 7, 2023 •
edited
Loading

Implements PYTHON-3822.

@ShaneHarvey ShaneHarvey requested a review from a team as a code owner November 7, 2023 23:47
@ShaneHarvey ShaneHarvey requested review from NoahStapp and removed request for a team November 7, 2023 23:47
@ShaneHarvey ShaneHarvey marked this pull request as draft November 7, 2023 23:47
@ShaneHarvey ShaneHarvey removed the request for review from NoahStapp November 7, 2023 23:47
@ShaneHarvey ShaneHarvey mentioned this pull request Nov 7, 2023
Merged
3 tasks
@ShaneHarvey
Copy link
Member Author

Blocked on mongodb/specifications#1473

@ShaneHarvey
Copy link
Member Author

Split off PYTHON-3170 to it's own PR here: #1424

@ShaneHarvey ShaneHarvey marked this pull request as ready for review November 21, 2023 20:36
@ShaneHarvey ShaneHarvey requested review from a team and blink1073 and removed request for a team November 21, 2023 20:36
@ShaneHarvey
Copy link
Member Author

Spec PR was merged without changes so this is also ready to merge.

@ShaneHarvey
Copy link
Member Author

@blink1073 waiting for your LGTM

blink1073
blink1073 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShaneHarvey ShaneHarvey merged commit 1a6f99c into mongodb:master Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaneHarvey @blink1073