Skip to content

PYTHON-3190 Test Failure - doctests failing cannot import name 'TypedDict' #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2022
Merged

PYTHON-3190 Test Failure - doctests failing cannot import name 'TypedDict' #917

merged 2 commits into from
Mar 31, 2022

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073
Copy link
Member Author

I scheduled a Doctests task

ShaneHarvey
ShaneHarvey reviewed Mar 31, 2022
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we were using the minimum python version for doctests intentionally to catch things like this where doc examples used features not all users could take advantage of. That said, it's probably fine to bump it.

@blink1073 blink1073 merged commit a809b3c into mongodb:master Mar 31, 2022
@blink1073 blink1073 deleted the PYTHON-3190 branch March 31, 2022 21:11
juliusgeo pushed a commit to juliusgeo/mongo-python-driver that referenced this pull request Apr 7, 2022
@blink1073 @juliusgeo
PYTHON-3190 Test Failure - doctests failing cannot import name 'Typed…
829ac17 
…Dict' (mongodb#917)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey left review comments

@juliusgeo juliusgeo Awaiting requested review from juliusgeo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @ShaneHarvey