chore: update tj actions #3063
Closed
chore: update tj actions #3063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gssbzn do you know if there is any blocker to update this? |
gssbzn
reviewed
Jun 28, 2024
| @@ -20,7 +20,7 @@ jobs: | |||
| run: echo "VERSION=$(curl -sSfL -X GET https://api.github.com/repos/mongodb/atlas-sdk-go/releases/latest | jq -r '.tag_name')" >> "$GITHUB_OUTPUT" | |||
| - run: make update-atlas-sdk | |||
| - name: Verify Changed files | |||
| uses: tj-actions/verify-changed-files@11ea2b36f98609331b8dc9c5ad9071ee317c6d28 | |||
| uses: tj-actions/verify-changed-files@v20 | |||
There was a problem hiding this comment.
can you please use the sha? or you can leave it until tuesday and dependabot will create a PR
There was a problem hiding this comment.
can I merge like this so snyk understand we're using a version > 17?
There was a problem hiding this comment.
also, can we keep a pinned version?
dependabot complains:
Dependabot can't update vulnerable dependencies without a pinned version
The currently installed version can't be determined.
To resolve the issue pin the version to a specific release in your manifest file.
There was a problem hiding this comment.
there's a request from security to keep 3rd party Gh actions (not mantained by GH) using shas instead of pinned version
There was a problem hiding this comment.
I see, i'll close this then! as it would come up again after we fix the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Trying to update this to resolve https://github.com/mongodb/mongodb-atlas-cli/security/dependabot
Checklist
make fmtand formatted my codeFurther comments