feat(NODE-6882): close outstanding connections #4499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

baileympearson merged 11 commits into main from NODE-6882-close-inuse

May 2, 2025

Contributor

nbbeeken commented Apr 4, 2025 •

edited

Loading

Description

What is changing?

connections that are in-use are interrupted by client.close to gracefully shutdown node

Is there new documentation needed for these changes?

Yes

What is the motivation for this change?

Graceful event loop exit

Release Highlight

MongoClient close shuts outstanding in-use connections

The MongoClient.close() method now shuts connections that are in-use allowing the event loop to close if the only remaining resource was the MongoClient.

Double check the following

Ran npm run check:lint script
Self-review completed using the steps outlined here
PR title follows the correct format: type(NODE-xxxx)[!]: description
- Example: feat(NODE-1234)!: rewriting everything in coffeescript
Changes are covered by tests
New TODOs have a related JIRA ticket

nbbeeken force-pushed the NODE-6882-close-inuse branch 5 times, most recently from 3b95935 to 4b798d7 Compare

April 4, 2025 19:04

nbbeeken force-pushed the NODE-6882-close-inuse branch 2 times, most recently from 0d71ec5 to 008c6dc Compare

April 24, 2025 14:52

nbbeeken marked this pull request as ready for review

April 24, 2025 15:19

nbbeeken requested a review from a team as a code owner

April 24, 2025 15:20

nbbeeken force-pushed the NODE-6882-close-inuse branch from 008c6dc to 67421a1 Compare

April 24, 2025 15:27

nbbeeken commented

View reviewed changes

test/integration/node-specific/mongo_client.test.ts Show resolved Hide resolved

nbbeeken commented

View reviewed changes

test/integration/node-specific/examples/causal_consistency.test.js Show resolved Hide resolved

nbbeeken commented

View reviewed changes

test/integration/index_management.test.ts Show resolved Hide resolved

nbbeeken commented

View reviewed changes

test/integration/change-streams/change_stream.test.ts Show resolved Hide resolved

nbbeeken commented

View reviewed changes

src/sdam/topology.ts Show resolved Hide resolved

nbbeeken commented

View reviewed changes

src/encrypter.ts Show resolved Hide resolved

baileympearson self-assigned this

baileympearson added the Primary Review label

baileympearson requested changes

View reviewed changes

src/cmap/connection_pool.ts Outdated Show resolved Hide resolved

src/mongo_client.ts Show resolved Hide resolved

src/error.ts Show resolved Hide resolved

src/error.ts Outdated Show resolved Hide resolved

test/integration/change-streams/change_stream.test.ts Show resolved Hide resolved

nbbeeken force-pushed the NODE-6882-close-inuse branch 6 times, most recently from 3159584 to 99d6a90 Compare

April 28, 2025 16:16

nbbeeken requested a review from baileympearson

April 28, 2025 16:54

baileympearson requested changes

View reviewed changes

src/cmap/connection_pool.ts Outdated Show resolved Hide resolved

src/mongo_client.ts Show resolved Hide resolved

src/error.ts Show resolved Hide resolved

src/cmap/connection_pool.ts Outdated Show resolved Hide resolved

nbbeeken requested a review from baileympearson

April 30, 2025 18:07

nbbeeken force-pushed the NODE-6882-close-inuse branch from 233531a to 91a3103 Compare

April 30, 2025 18:14

baileympearson reviewed

View reviewed changes

src/error.ts Outdated Show resolved Hide resolved

baileympearson reviewed

View reviewed changes

test/integration/connection-monitoring-and-pooling/connection_pool.test.ts Outdated Show resolved Hide resolved

nbbeeken requested a review from baileympearson

April 30, 2025 19:53

nbbeeken force-pushed the NODE-6882-close-inuse branch from d9ccf0b to ff8e814 Compare

April 30, 2025 20:05

baileympearson requested changes

View reviewed changes

test/integration/node-specific/mongo_client.test.ts Show resolved Hide resolved

src/cmap/connection_pool.ts Outdated Show resolved Hide resolved

nbbeeken requested a review from baileympearson

May 1, 2025 16:23

baileympearson requested changes

View reviewed changes

test/integration/node-specific/mongo_client.test.ts Show resolved Hide resolved

test/integration/node-specific/mongo_client.test.ts Show resolved Hide resolved

nbbeeken requested a review from baileympearson

May 1, 2025 20:36

nbbeeken force-pushed the NODE-6882-close-inuse branch 4 times, most recently from cb5bd62 to 4c11661 Compare

May 2, 2025 16:49

nbbeeken added 11 commits

May 2, 2025 15:09


          feat(NODE-6882): close checked out connection in MongoClient.close()

e0213df


          docs and force flag

7f711c4


          chore: close naming

5ea0fc7


          chore: remove ConnectionPoolClosedError

a733ed7


          chore: add test to demonstrate check in

b31b403


          test: check-in before close

f376ce7


          chore: update error message

6674aa8


          chore: error and checkin

f04fbd4


          test: deadlock if in-use connections not closed

ffed234


          metadata filter not working?

5082c66


          test: make sure the getMore is started

a46ca1d

nbbeeken force-pushed the NODE-6882-close-inuse branch from 4c11661 to a46ca1d Compare

May 2, 2025 19:10

baileympearson approved these changes

View reviewed changes

Contributor

baileympearson left a comment

LGTM pending CI.

baileympearson merged commit 64fdb3e into main

31 checks passed

baileympearson deleted the NODE-6882-close-inuse branch

May 2, 2025 20:37

github-actions bot mentioned this pull request

chore(main): release 6.17.0 [skip-ci] #4518

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels