-
Notifications
You must be signed in to change notification settings - Fork 1.8k
test(NODE-6891): add coverage for all test runs #4508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a7de81e
to
a85be3c
Compare
Note that this PR didn't work for all OIDC tests, only the main test run, not all the individual container tests (AWS/GCP/Azure). Since this was intended to be a quick win ticket and timeboxed, I'm just putting it as ready for review to not spend more time on it now over prioritized work. |
I've created NODE-6908 as a follow up for the container based tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but suspiciously x509 still is "uncovered" but we do have tests for it:
and I can see the coverage report uploaded here, any ideas?
We seem to be excluding rhel80-large from our coverage reports. Do you know a reason why and can I just remove that exclude?
|
"rhel80-large" is our default OS so its first excluding all of our linux tasks then including just the "fermiun"... which is Node.js 14 🤨 so maybe these conditions need an update (it is also misspelled, it's Fermium) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Update all relevant test runs to run with nyc to get better coverage reports.
What is changing?
Update package.json to prefix mocha runs with nyc.
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-6891
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript