-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(NODE-6245): add keepAliveInitialDelay config #4510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Capturing from our meeting: we want to get the keepAlive related options into the "options" argument we pass into KeepAlive will still always be enabled and not configurable. |
Co-authored-by: Neal Beeken <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (I'll get a ping when the CI finishes)
Failures look all like the FLE bad uri test that has the slack thread. |
Description
Brings back the
keepAliveInitialDelay
option.What is changing?
keepAliveInitialDelay
as an option to pass to the socket.setKeepAlive
andsetNoDelay
Is there new documentation needed for these changes?
Yes, driver docs.
What is the motivation for this change?
NODE-6245
Release Highlight
keepAliveInitialDelay
may now be configured at theMongoClient
levelWhen not present will default to 120 seconds. The option value must be specified in milliseconds.
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript