chore(NODE-6939): update typescript to 5.8.3 #4526
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
commented
Apr 30, 2025
baileympearson
added
the
Primary Review
baileympearson
requested changes
Apr 30, 2025
package-lock.json
Outdated
| @@ -60,7 +60,7 @@ | |||
| "source-map-support": "^0.5.21", | |||
| "ts-node": "^10.9.2", | |||
| "tsd": "^0.31.2", | |||
There was a problem hiding this comment.
The AC says to update tsd as well
There was a problem hiding this comment.
Updated and issues fixed. I needed to remove some tests from the slow model tests (since we cannot use namespaced types anymore) but don't think that impacts what that was actually testing.
durran
force-pushed
the
NODE-6939
branch
2 times, most recently
from
d7b78f0 to
beb0929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates typescript to 5.8.3
What is changing?
erasableSyntaxOnlyoption.Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-6939
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript