-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(NODE-6955): add missing wallTime
property to applicable change stream documents
#4541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
baileympearson
merged 11 commits into
mongodb:main
from
qhello:qhello-add-walltime-to-change-stream-type
Jun 4, 2025
Merged
fix(NODE-6955): add missing wallTime
property to applicable change stream documents
#4541
baileympearson
merged 11 commits into
mongodb:main
from
qhello:qhello-add-walltime-to-change-stream-type
Jun 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88a44b8
to
1e9b269
Compare
96cec89
to
1530f4c
Compare
baileympearson
requested changes
Jun 2, 2025
wallTime
property to ChangeStreamDocumentCommon
wallTime
property to applicable change stream documents
baileympearson
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
External Submission
PR submitted from outside the team
Team Review
Needs review from team
tracked-in-jira
Ticket filed in MongoDB's Jira system
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Adds missing
wallTime: Date
property toChangeStreamDocumentCommon
type.Is there new documentation needed for these changes?
None
What is the motivation for this change?
I needed to use the
wallTime
property from my change stream messages, but noticed that the property is missing frommongodb
built-in types.Release Highlight
ChangeStream event interfaces include a
wallTime
propertyThis property is available on all types with the exception of reshard collection and refine collection shard key events. Thanks to @qhello for bringing this bug to our attention!
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript