Skip to content

fix(NODE-6955): add missing wallTime property to applicable change stream documents #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

qhello
Copy link
Contributor

@qhello qhello commented May 20, 2025

Description

What is changing?

Adds missing wallTime: Date property to ChangeStreamDocumentCommon type.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

I needed to use the wallTime property from my change stream messages, but noticed that the property is missing from mongodb built-in types.

Release Highlight

ChangeStream event interfaces include a wallTime property

This property is available on all types with the exception of reshard collection and refine collection shard key events. Thanks to @qhello for bringing this bug to our attention!

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • [] New TODOs have a related JIRA ticket

@qhello qhello requested a review from a team as a code owner May 20, 2025 14:12
@dariakp dariakp added tracked-in-jira Ticket filed in MongoDB's Jira system External Submission PR submitted from outside the team labels May 20, 2025
@durran durran force-pushed the qhello-add-walltime-to-change-stream-type branch from 88a44b8 to 1e9b269 Compare May 27, 2025 13:51
@durran durran self-assigned this May 27, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 27, 2025
@durran durran force-pushed the qhello-add-walltime-to-change-stream-type branch from 96cec89 to 1530f4c Compare May 28, 2025 17:39
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 2, 2025
@baileympearson baileympearson self-requested a review June 2, 2025 16:47
@durran durran requested a review from baileympearson June 2, 2025 17:14
@durran durran changed the title fix(NODE-6955): add missing wallTime property to ChangeStreamDocumentCommon fix(NODE-6955): add missing wallTime property to applicable change stream documents Jun 2, 2025
@baileympearson baileympearson merged commit f153c6f into mongodb:main Jun 4, 2025
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Submission PR submitted from outside the team Team Review Needs review from team tracked-in-jira Ticket filed in MongoDB's Jira system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants