Dogfood #280
Merged
Dogfood #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #280 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 60 60
Lines 2550 2550
=======================================
Hits 2523 2523
Misses 27 27
Continue to review full report at Codecov.
|
Ensure that this repo is leading by example, and eating its own dogfood. Also reduces flake8 ignore list to only W503,W504, and updates the flake8 max line length to match black. And separate commands in test.bat with %errorlevel% handling.
|
A better solution for the test.bat / lint.sh / test.sh problem is to write a test.bat and lint.bat which also runs on bash https://stackoverflow.com/a/46813196 Please advise whether you would like me to do that (and backport it to the templates) |
chfw
reviewed
Jul 8, 2019
| @@ -1,6 +1,5 @@ | |||
| import moban.constants as constants | |||
There was a problem hiding this comment.
this is done by isort. I will checkout its configuration
chfw
reviewed
Jul 8, 2019
| lint_command: make lint install_test format install update |
There was a problem hiding this comment.
I did not realize it is 'lint_command'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.