Skip to content

setup.py: Add codecs and locale hacks #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2018

Conversation

Naveenaidu
Copy link
Collaborator

codec and locale hacks have been added to avoid
breakages in setup.py

Closes #46

@Naveenaidu Naveenaidu force-pushed the add_codecs_locale_hacks branch 4 times, most recently from 5f35523 to a2eeb5f Compare November 20, 2018 15:57
@chfw
Copy link
Member

chfw commented Nov 20, 2018

please update change log, describing what's included.

@chfw
Copy link
Member

chfw commented Nov 20, 2018

and I am sorry that I have not given feedback on time.

codec and locale hacks have been added to avoid
breakages in setup.py

Closes moremoban#46
@Naveenaidu Naveenaidu force-pushed the add_codecs_locale_hacks branch from a2eeb5f to d0f5717 Compare November 21, 2018 07:28
@Naveenaidu
Copy link
Collaborator Author

and I am sorry that I have not given feedback on time.

No problem at all :)

Copy link
Member

@chfw chfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@chfw chfw merged commit 808a80c into moremoban:dev Nov 21, 2018
@chfw chfw mentioned this pull request Jan 18, 2019
chfw added a commit that referenced this pull request Jan 18, 2019
chfw added a commit that referenced this pull request Jan 18, 2019
@chfw chfw mentioned this pull request Jan 18, 2019
chfw added a commit that referenced this pull request Jan 18, 2019
chfw added a commit that referenced this pull request Jan 18, 2019
🐛 fix missing import platform. #60
@chfw chfw mentioned this pull request Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants