support arduino-cli 1.0 json format #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahihi
force-pushed
the
1.0-json-format
branch
from
f2c853d to
c0382db
Compare
ahihi
force-pushed
the
1.0-json-format
branch
from
c0382db to
7cbf2bf
Compare
|
had a chance to try this today with an Arduino Nano and noticed i made a silly typo. fixed now and it is working fine as far as i can tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully fixes #11, which i only noticed after encountering and patching this myself.
i know i have commit rights, but i would like others to test this before merging. i only had an
esp8266:esp8266:nodemcuv2board on hand, which has nomatching_boardsinfo, so i have to setarduino-cli-default-fqbnandarduino-cli-default-portmanually, which skips some of the code dealing with arduino-cli output.relevant change in arduino-cli: arduino/arduino-cli#2407