This repository was archived by the owner on Sep 2, 2020. It is now read-only.
Adding support for config-store #135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same code as openbadges-badgekit config.json now supported as documented in Badgekit Self Hosting Guide
|
Thanks, @BrunoWinck! The slight differences that had existed between how badgekit admin and badgekit-api were configured have posed a number of user questions over the months. It would be cool to bring the config.json approach to badgekit-api. I haven't tested this PR code, but the purpose is sound. Ping @simonwex -- Bruno was wondering who's reviewing badgekit issues at the moment. Do you know? |
|
@ottonomy, short answer: there isn't anyone currently. I'm working on that, could you add anything else that's pressing to the OBI 1.1 & Maintenance Work milestone? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same code as openbadges-badgekit
config.json now supported as documented in Badgekit Self Hosting Guide