Added "data-" to fields, so page maintains HTML5 compatibility #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed so field properties are html5 compliant
mrchandoo
reviewed
Dec 16, 2017
| @@ -59,7 +59,7 @@ - (void) addDecimalButton{ | |||
| decimalButton = [UIButton buttonWithType:UIButtonTypeCustom]; | |||
| [self setDecimalChar]; | |||
| [decimalButton setTitleColor:[UIColor colorWithRed:0/255.0 green:0/255.0 blue:0/255.0 alpha:1.0] forState:UIControlStateNormal]; | |||
| decimalButton.titleLabel.font = [UIFont systemFontOfSize:40.0]; | |||
| decimalButton.titleLabel.font = [UIFont systemFontOfSize:30.0]; | |||
There was a problem hiding this comment.
Any reason why the font size is reduced ?
| @@ -59,7 +59,7 @@ - (void) addDecimalButton{ | |||
| decimalButton = [UIButton buttonWithType:UIButtonTypeCustom]; | |||
| [self setDecimalChar]; | |||
| [decimalButton setTitleColor:[UIColor colorWithRed:0/255.0 green:0/255.0 blue:0/255.0 alpha:1.0] forState:UIControlStateNormal]; | |||
| decimalButton.titleLabel.font = [UIFont systemFontOfSize:40.0]; | |||
| decimalButton.titleLabel.font = [UIFont systemFontOfSize:30.0]; | |||
There was a problem hiding this comment.
Also i would suggest we better allow both decimal and data-decimal, so that its compatible with old plugin.
There was a problem hiding this comment.
The font size alteration was needed in my project, I'll turn it into a preference to be in the config of the plugin, so people can use the size they want.
Also I'll alter this to allow both "data-decimal" and "decimal" to keep compatibility as you suggest.
I'll try to get around it next week as I have to check an iOS11 compatibility issue with this plugin (check the issue I wrote) and make a new pull request with your feedback added.
Thanks.
…een fields with the same keyboard type, this exposes two functions to solve this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "data-" to custom attribute fields, so page maintains HTML5 compatibility (some code generating platforms will not allow invalid fields, so this mitigates that problem).
Also reduced decimal separator size for aesthetic purposes (this could be a parameter in the config, but haven't applied it in this change).