-
-
Notifications
You must be signed in to change notification settings - Fork 464
Add ProcessLineAgainstMesh
#3178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
does it take an account animated models like 3425? i expect that when i use this function the results will match what i see. also, does it work for peds and vehicles? |
No clue, haven't tried. |
…ocessLineAgainstMesh
botder
requested changes
Sep 17, 2023
I've applied the requested suggestions. |
botder
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new function
ProcessLineAgainstMesh
, that is supposed to do a raycast against an element's renderable mesh model [not the collision model!].The same functionality is already present in #3099, but the latter is a little buggy due to the fact that the collision model is always simplified, and not exactly the same as the mesh, and this leads to situations where no hit is detected, even though the visible mesh is hittable.
Also, when one is interested in a specific element the overhead is a lot smaller [as we can skip all the collision detection done by
processLineOfSight
]The reason I didn't make it be a standalone function in the beginning is that not all game entitites can be represented as
CClientEntity
[For example IPL objects].