fix!(argon2): respect the salt provided in hash options #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
Brooooooklyn
force-pushed
the
10-03-fix_argon2_respect_the_salt_provided_in_hash_options
branch
from
48bcaff to
15d9c79
Compare
|
@Brooooooklyn you sir are a gentleman and a scholar 🙏 was debating putting in a PR myself but I saw there wasn't much activity here in a while other than dep bots. Then I was watching a recent Nx update vid and you got a personal shoutout for helping them with some wasi... I was like, wait... where have I heard that name before. Then it all made sense haha. Busy guy. Appreciate you getting that sorted promptly, PR looks good. Was just thinking if it would need updated benchmarks, but I guess the salt doesn't effect the speed of the hash computation so shouldn't be necessary. Thanks again |
Brooooooklyn
deleted the
10-03-fix_argon2_respect_the_salt_provided_in_hash_options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.