Skip to content

react-testing-library -> react-hooks-testing-library #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2019

Conversation

jackdclark
Copy link
Contributor

@jackdclark jackdclark commented Feb 26, 2019

Closes #51

react-testing-library moved the testHook util to a separate package in #307 to discourage unit testing component implementation details. graphql-hooks is a library of custom hooks that aren't directly tied to components, therefore it makes sense to migrate to this package to use this util, given that we aren't using any other features from react-testing-library.

@jackdclark jackdclark merged commit 453fbcf into master Feb 26, 2019
@jackdclark jackdclark deleted the react-hooks-testing-library branch February 26, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants