Fix DateTime with ZoneId unpacking #1098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timezone offset was miss-calculated because of an error on extracting timezone information when the hour equals to `0`. The problems happens because `Intl.DateTimeFormat` when configured with `hour12: false` returns `0` hour as `24`. The solution for this is convert `24` to `0` before calculate the `offset`. NOTE: Other valid solution would be change `hourCycle` to `h23`. However, this solution is not supported by all javascript environment.
ConorNeo
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timezone offset was miss-calculated because of an error on extracting timezone information when the hour equals to
0. The problems happens becauseIntl.DateTimeFormatwhen configured withhour12: falsereturns0hour as24.The solution for this is convert
24to0before calculate theoffset.NOTE:
Other valid solution would be change
hourCycletoh23. However, this solution is not supported by all javascript environment.Backports: #1097