Make known-host file to tolerate duplicated serverId #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on the first one and not call the callback on `loadFingerprint` more than once
| var text = fs.readFileSync(knownHostsPath,'utf8'); | ||
| fs.writeFileSync(knownHostsPath, text+text); | ||
| }, 1000); | ||
|
|
||
| // When | ||
| driver.session().run("RETURN true AS a").then( function(data) { |
There was a problem hiding this comment.
This should be encapsulated in a setTimeout(2000) in order to wait for the above one to duplicate the file data
There was a problem hiding this comment.
This test passed on test server. So maybe the timeout is okay? Though currently we just tested on linux, our windows test server might require longer to see the change. Currently the test failed at a known tck failing test :D I am trying to fix it now so get this PR ready.
There was a problem hiding this comment.
Yes, but since driver.session().run() will fire off the queue at an arbitrary time, you cannot know if the file has been modified to have duplicated lines yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is more than one dup in the known-host file, then the first one will be picked.
Based on #110