Deprecate TRUST_SIGNED_CERTIFICATES #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm but I cannot merge since github says it has conflicts. |
TRUST_SIGNED_CERTIFICATES does different things on different platforms. It has now been deprecated and user should use TRUST_CUSTOM_CA_SIGNED_CERTIFICATES instead.
pontusmelke
force-pushed
the
1.0-cleanup-tls-opts
branch
from
4287c68 to
01b76b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRUST_SIGNED_CERTIFICATESis behaving differently on different platforms. Inorder to clean this up we deprecate it and replace with
TRUST_SYSTEM_CA_SIGNED_CERTIFICATESwhich trusts the system defaults on theplatform
TRUST_CUSTOM_CA_SIGNED_CERTIFICATESwhich trusts a particular rootcertificate (can be a self-signed certificate for example)