Expose server info in result summary from sessions and transactions #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need rebase to fix the driver version |
lutovich
force-pushed
the
1.1-expose-server-info
branch
2 times, most recently
from
537acf0 to
69cde8c
Compare
|
What about unhappy case where we failed to run a query and how does a user still access |
Exposed as a map in `result.summary.server`:
```
{
address: 'localhost:7687',
version: 'Neo4j/3.1.0'
}
```
lutovich
force-pushed
the
1.1-expose-server-info
branch
from
fb80079 to
afbbbd9
Compare
|
Rebased. Currently there exists no API to retrieve summary after failure. I think it should be added in a separate PR. Also added couple tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed as a map in
result.summary.server: