Skip to content

README improvements #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 5, 2017
Merged

README improvements #186

merged 4 commits into from
Jan 5, 2017

Conversation

lutovich
Copy link
Contributor

@lutovich lutovich commented Jan 5, 2017

PR adds following entries to the README.md:

  • need for driver.close()
  • ordering of onNext, onCompleted and onError callbacks
  • existence of driver.onCompleted and driver.onError callbacks

Closes #151 #185 #120

@zhenlineo
Copy link
Contributor

LGTM, I suggest also include driver.close in the example to be more clear about it.

@lutovich
Copy link
Contributor Author

lutovich commented Jan 5, 2017

@zhenlineo added driver.close() to the "Usage examples" section.

@zhenlineo zhenlineo merged commit 6972a9a into neo4j:1.1 Jan 5, 2017
@lutovich lutovich deleted the 1.1-doc-improvements branch January 5, 2017 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants