Align routing to spec #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unused methods, simplified remove operation and added couple tests.
It contains 3 round robin arrays: routers, readers and writers. It also contains an expiration timestamp which corresponds to `ttl` received from `getServers` procedure call.
Previously it was mostly located in routing driver which owned the cluster view and all logic to call `getServers` and interpret it's output/failures. This introduces two new internal components: * `GetServersUtil` - responsible for calling `getServers` procedure and processing it's output * `Rediscovery` - responsible for fetching a routing table from the specified server Routing driver now owns a routing table and an instance of rediscovery. It uses the later one to update the routing table when needed. Added dev dependency to lolex(https://github.com/sinonjs/lolex) to be able to mock system time and test things better.
And add early validation of the session mode parameter.
Previously session and the underlying connection were not returned to the pool after the rediscovery procedure. This happened because rediscovery session was not initalized with an appropriate callback. This commit fixes the problem by extracting the release callback code into a function that gets called for both "normal" and "rediscovery" sessions. Probably a cleaner way to fix this would be to move functionality into `Session#close()` and make connection release itself to the pool. However this resulted into lots of non-trivial changes and thus should go into a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that
bolt+routingworks the same way as in other drivers. This means all errors and exceptional conditions are handled consistently.It changes quite a bit of things around routing and introduces abstractions similar to Java driver:
RoutingTableGetServersUtilRediscoveryPlease read individual commit messages for more details.