Unpack failure messages to Neo4jErrors #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously raw FAILURE message was passed to `onError`-like callbacks and
thrown as is. This means thrown error contained packstream related fields and
actually was a packstream structure. Example:
```
Structure {
signature: 127,
fields: [
{
code: 'Neo.ClientError.Schema.ConstraintValidationFailed',
message: 'Node 0 already exists with label A and property "a"=[42]'
}
]
}
```
This commit makes sure we unpack/convert FAILURE messages to `Neo4jError`s
and pass those further to callbacks.
lutovich
force-pushed
the
1.1-single-err-format
branch
from
1330243 to
517e47d
Compare
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously raw FAILURE message was passed to
onError-like callbacks and thrown as is. This means thrown error contained packstream related fields and actually was a packstream structure. Example:This commit makes sure we unpack/convert FAILURE messages to
Neo4jErrors and pass those further to callbacks.Fixes #201