Represent Cypher DateTime with a single type #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DateTime contains time zone information. It might either be an offset
in seconds (that corresponds to ±HH:MM) or the time zone id
(like 'Europe/London'). Previously driver exposed DateTime as two
different types: `DateTimeWithZoneOffset` and `DateTimeWithZoneId`.
This commit combines them into a single type:
```
class DateTime {
year: Integer|number,
month: Integer|number,
day: Integer|number,
hour: Integer|number,
minute: Integer|number,
second: Integer|number,
nanosecond: Integer|number,
timeZoneOffsetSeconds: Integer|number,
timeZoneId: string
}
```
where either `timeZoneOffsetSeconds` or `timeZoneId` is defined. Such
single type better corresponds to the Cypher DateTime type and feels
more idiomatic to JavaScript. Shape of objects (set of their properties)
feels more important than the class/type.
Also renamed `Time.offsetSeconds` to `Time.timeZoneOffsetSeconds` to
better represent the meaning of the property.
lutovich
force-pushed
the
1.6-single-DateTime-type
branch
from
959ff20 to
51b8b91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTime contains time zone information. It might either be an offset in seconds (that corresponds to ±HH:MM) or the time zone id (like 'Europe/London'). Previously driver exposed DateTime as two different types:
DateTimeWithZoneOffsetandDateTimeWithZoneId.This PR combines them into a single type:
where either
timeZoneOffsetSecondsortimeZoneIdis defined. Such single type better corresponds to the Cypher DateTime type and feels more idiomatic to JavaScript. Shape of objects (set of their properties) feels more important than the class/type.Also renamed
Time.offsetSecondstoTime.timeZoneOffsetSecondsto better represent the meaning of the property.